Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print base64 string value for a key if public. #1092

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

melowe
Copy link
Contributor

@melowe melowe commented Jun 24, 2020

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1092 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1092   +/-   ##
=========================================
  Coverage     99.39%   99.39%           
- Complexity     2263     2264    +1     
=========================================
  Files           350      350           
  Lines          6291     6298    +7     
  Branches        360      360           
=========================================
+ Hits           6253     6260    +7     
  Misses            5        5           
  Partials         33       33           
Flag Coverage Δ Complexity Δ
#unittests 99.39% <100.00%> (+<0.01%) 2264.00 <1.00> (+1.00)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/quorum/tessera/encryption/BaseKey.java 100.00% <100.00%> (ø) 8.00 <0.00> (ø)
...a/com/quorum/tessera/encryption/PublicKeyImpl.java 100.00% <100.00%> (ø) 2.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b791f89...ddbf6d2. Read the comment docs.

@melowe melowe merged commit 8ebfce7 into master Jun 24, 2020
@melowe melowe deleted the key_to_string branch June 24, 2020 13:41
@Krish1979 Krish1979 added 0.10.6 cleanup bug Something isn't working and removed cleanup labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.6 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants