Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PrivacyGroupId in payload #1239

Merged
merged 14 commits into from
Feb 5, 2021
Merged

Conversation

namtruong
Copy link
Collaborator

A part of #1216.

This PR is specific to

  • Include PrivacyGroupId in EncodedPayload
  • Include PrivacyGroupId in send and receive domain objects
  • Modify enclave encrypt signature to also include privacy group id
  • Changes to the payload encoder and unit tests to ensure backward compatibility

@codecov-io
Copy link

Codecov Report

Merging #1239 (4f5a7e8) into master (09a715a) will decrease coverage by 0.00%.
The diff coverage is 99.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1239      +/-   ##
============================================
- Coverage     99.53%   99.52%   -0.01%     
- Complexity     3224     3226       +2     
============================================
  Files           496      497       +1     
  Lines          9575     9682     +107     
  Branches        483      488       +5     
============================================
+ Hits           9530     9636     +106     
  Misses            5        5              
- Partials         40       41       +1     
Flag Coverage Δ Complexity Δ
unittests 99.52% <99.66%> (-0.01%) 0.00 <22.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../main/java/com/quorum/tessera/enclave/Enclave.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...ava/com/quorum/tessera/enclave/EncodedPayload.java 99.03% <96.66%> (-0.97%) 25.00 <2.00> (+2.00) ⬇️
...n/java/com/quorum/tessera/enclave/EnclaveImpl.java 100.00% <100.00%> (ø) 41.00 <1.00> (ø)
...com/quorum/tessera/enclave/PayloadEncoderImpl.java 99.42% <100.00%> (-0.58%) 20.00 <1.00> (+1.00) ⬇️
...va/com/quorum/tessera/enclave/PrivacyMetadata.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...om/quorum/tessera/enclave/rest/EnclavePayload.java 100.00% <100.00%> (ø) 15.00 <2.00> (+2.00)
...quorum/tessera/enclave/rest/EnclaveRawPayload.java 100.00% <100.00%> (ø) 19.00 <2.00> (+2.00)
...m/quorum/tessera/enclave/rest/EnclaveResource.java 100.00% <100.00%> (ø) 21.00 <3.00> (ø)
...rum/tessera/enclave/rest/RestfulEnclaveClient.java 99.35% <100.00%> (+0.03%) 31.00 <3.00> (-2.00) ⬆️
...tessera/transaction/EncodedPayloadManagerImpl.java 100.00% <100.00%> (ø) 8.00 <0.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a715a...e041fb2. Read the comment docs.

@Krish1979 Krish1979 merged commit 2b99e7d into master Feb 5, 2021
@namtruong namtruong deleted the include-groupid-in-payload branch February 5, 2021 10:08
@Krish1979 Krish1979 added 21.1.1 Tessera Q1 2021 release Besu Compatibility labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21.1.1 Tessera Q1 2021 release Besu Compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants