Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resident privacy group and validations #1273

Merged
merged 18 commits into from
Apr 30, 2021
Merged

Conversation

namtruong
Copy link
Collaborator

  • Introduce feature config enableMultiplePrivateStates to accommodate Quorum handling multiple private states
  • Introduce RESIDENT privacy group type
  • Allow resident groups and its member to be configured via config file
  • Resident groups configured will be validated and created upon application launch.
  • Introduce groups API to return a list of privacy groups of a specific type. Usage groups/resident
  • A member cannot belong to more than 1 resident group, nor switch between groups.
  • If user decides to switch on mps feature, all keys configured must belong to a resident group.

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #1273 (ab225e6) into master (4a3d8e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #1273    +/-   ##
==========================================
  Coverage     99.52%   99.52%            
- Complexity     3251     3291    +40     
==========================================
  Files           499      502     +3     
  Lines          9811     9939   +128     
  Branches        491      494     +3     
==========================================
+ Hits           9764     9892   +128     
  Misses            5        5            
  Partials         42       42            
Flag Coverage Δ Complexity Δ
unittests 99.52% <100.00%> (+<0.01%) 3291.00 <47.00> (+40.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ava/com/quorum/tessera/context/RuntimeContext.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...va/com/quorum/tessera/data/PrivacyGroupEntity.java 100.00% <ø> (ø) 14.00 <0.00> (ø)
...rc/main/java/com/quorum/tessera/config/Config.java 100.00% <100.00%> (ø) 40.00 <2.00> (+2.00)
...java/com/quorum/tessera/config/FeatureToggles.java 100.00% <100.00%> (ø) 13.00 <3.00> (+3.00)
.../java/com/quorum/tessera/config/ResidentGroup.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
.../java/com/quorum/tessera/enclave/PrivacyGroup.java 98.55% <100.00%> (+0.19%) 0.00 <0.00> (ø)
...a/com/quorum/tessera/enclave/PrivacyGroupUtil.java 100.00% <100.00%> (ø) 12.00 <3.00> (+2.00)
.../quorum/tessera/context/DefaultRuntimeContext.java 100.00% <100.00%> (ø) 15.00 <2.00> (+1.00)
.../tessera/context/DefaultRuntimeContextFactory.java 98.46% <100.00%> (+0.02%) 11.00 <4.00> (ø)
.../quorum/tessera/context/RuntimeContextBuilder.java 100.00% <100.00%> (ø) 17.00 <1.00> (+1.00)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280cd19...ab225e6. Read the comment docs.

Copy link
Contributor

@nicolae-leonte-go nicolae-leonte-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Krish1979 Krish1979 merged commit fa7b943 into master Apr 30, 2021
@Krish1979 Krish1979 added 21.4.0 enhancement Non-user code enhancements feature User features labels May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21.4.0 enhancement Non-user code enhancements feature User features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants