Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve keygen CLI output, fix security advisories in key vault modules #1464

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Improve keygen CLI output, fix security advisories in key vault modules #1464

merged 4 commits into from
Jun 22, 2022

Conversation

chris-j-h
Copy link
Collaborator

@chris-j-h chris-j-h commented Jun 22, 2022 •
edited

  • Print keygen results to stdout as current results are buried in log msgs
    • Output includes: generated public key, key-storage specific information (e.g. filepath, vault secret id)
  • Update key-vault modules to address non-critical security advisories

Example keygen command and output:

$ tessera keygen --keyout /keys/test

1 keypair(s) generated:
	1: type=file, pub=WO5Wj+tXIxf8Amrv6RiOuAqXWGESatnscjal8AmV1AY=
		pub: path=/keys/test.pub
		prv: path=/keys/test.key

@chris-j-h
switch azure http client from netty to okhttp
a45837c 
resolves repeated cve dependency advisories from netty components & latest versions have java module issues that cannot be easily resolved
@chris-j-h
print keygen command results to stdout
08e8c59 
users should have results from a CLI command clearly printed to stdout and not have to look through logs
@chris-j-h
update CVE suppressions, stop unnecessary warnings from dependencyChe…
df93dc7 
…ck task
antonydenyer
antonydenyer approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@antonydenyer antonydenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Krish1979 Krish1979 merged commit e05a99f into Consensys:master Jun 22, 2022
@chris-j-h chris-j-h deleted the security-advisories-and-keygen-output branch June 22, 2022 14:56
@macfarla macfarla added the 22.1.4 label Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonydenyer antonydenyer antonydenyer approved these changes

@Krish1979 Krish1979 Awaiting requested review from Krish1979 Krish1979 is a code owner

@namtruong namtruong Awaiting requested review from namtruong namtruong is a code owner

@nicolae-leonte-go nicolae-leonte-go Awaiting requested review from nicolae-leonte-go

Assignees
No one assigned
Labels
22.1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chris-j-h @antonydenyer @macfarla @Krish1979