Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create basic modules and build files. #2

Merged
merged 3 commits into from
May 23, 2018
Merged

Create basic modules and build files. #2

merged 3 commits into from
May 23, 2018

Conversation

melowe
Copy link
Contributor

@melowe melowe commented May 23, 2018

Very simple ServiceLocator for Spring configured beans..


import javax.validation.constraints.NotNull;


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a very trivial point, but do we need so much whitespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not trivial.. we can add that to the check style stuff

@@ -44,7 +44,7 @@ public void requestVersion() {

javax.ws.rs.core.Response response = client
.target(SERVICE_URI)
.path("/api/version")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I thought I'd changed that, but obviously missed it!

<artifactId>nexus</artifactId>
<version>1.0-SNAPSHOT</version>
</parent>
<artifactId>service-locator</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the artifact details first in all the other poms, to make them consistent. It would be good to keep them all consistent, it just makes it easier when looking through all the poms or comparing them.

@melowe melowe merged commit 607b0e8 into master May 23, 2018
@melowe melowe deleted the mark-work branch May 27, 2018 19:55
melowe added a commit that referenced this pull request Jun 28, 2018
@melowe
Copy link
Contributor Author

melowe commented Aug 3, 2018

Basic rest server and implementation created via service loader mechanism. Sample load to demonstrate usage.

@melowe melowe changed the title Mark work Create basic modules and build files. Aug 3, 2018
Krish1979 pushed a commit that referenced this pull request Sep 13, 2018
Move rest tests into dedicated package.
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4e86f7e). Click here to learn what that means.
The diff coverage is 99.43%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master      #2   +/-   ##
========================================
  Coverage          ?   99.4%           
  Complexity        ?    2147           
========================================
  Files             ?     327           
  Lines             ?    6239           
  Branches          ?     320           
========================================
  Hits              ?    6202           
  Misses            ?       5           
  Partials          ?      32
Impacted Files Coverage Δ Complexity Δ
...quorum/tessera/data/migration/CmdLineExecutor.java 100% <ø> (ø) 6 <0> (?)
...rum/tessera/data/migration/DirectoryStoreFile.java 100% <ø> (ø) 5 <0> (?)
...um/tessera/data/migration/DataExporterFactory.java 100% <ø> (ø) 3 <0> (?)
...a/com/quorum/tessera/data/migration/DataEntry.java 100% <ø> (ø) 3 <0> (?)
.../com/quorum/tessera/data/migration/ExportType.java 100% <ø> (ø) 1 <0> (?)
...com/quorum/tessera/data/migration/BdbDumpFile.java 96.66% <ø> (ø) 8 <0> (?)
...um/tessera/config/cli/parsers/KeyUpdateParser.java 100% <100%> (ø) 14 <14> (?)
.../java/com/quorum/tessera/config/KeyDataConfig.java 100% <100%> (ø) 9 <9> (?)
...tessera/config/adapters/PrivateKeyTypeAdapter.java 100% <100%> (ø) 6 <6> (?)
...rc/main/java/com/quorum/tessera/cli/CliResult.java 100% <100%> (ø) 4 <4> (?)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e86f7e...922109a. Read the comment docs.

melowe added a commit that referenced this pull request Oct 15, 2019
…ctory

Peer to Peer Partyinfo and transaction syncing over websockets
Emi14 pushed a commit to Emi14/tessera that referenced this pull request Dec 20, 2019
…gerDone

AWS Secrets Manager implementation for KeyVault added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants