-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create basic modules and build files. #2
Conversation
|
||
import javax.validation.constraints.NotNull; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a very trivial point, but do we need so much whitespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not trivial.. we can add that to the check style stuff
@@ -44,7 +44,7 @@ public void requestVersion() { | |||
|
|||
javax.ws.rs.core.Response response = client | |||
.target(SERVICE_URI) | |||
.path("/api/version") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I thought I'd changed that, but obviously missed it!
<artifactId>nexus</artifactId> | ||
<version>1.0-SNAPSHOT</version> | ||
</parent> | ||
<artifactId>service-locator</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put the artifact details first in all the other poms, to make them consistent. It would be good to keep them all consistent, it just makes it easier when looking through all the poms or comparing them.
Basic rest server and implementation created via service loader mechanism. Sample load to demonstrate usage. |
Move rest tests into dedicated package.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
========================================
Coverage ? 99.4%
Complexity ? 2147
========================================
Files ? 327
Lines ? 6239
Branches ? 320
========================================
Hits ? 6202
Misses ? 5
Partials ? 32
Continue to review full report at Codecov.
|
…ctory Peer to Peer Partyinfo and transaction syncing over websockets
…gerDone AWS Secrets Manager implementation for KeyVault added
Very simple ServiceLocator for Spring configured beans..