Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload decoding update #501

Merged
merged 1 commit into from Oct 22, 2018
Merged

Payload decoding update #501

merged 1 commit into from Oct 22, 2018

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Oct 18, 2018

When decoding a payload that has no recipients, return an empty list without further inspection of the byte buffer.

This reduces the need to calling methods to determine ahead of time
which of the decode methods should be called.

without further inspection of the byte buffer.

This reduces the need to calling methods to determine ahead of time
which of the decode methods should be called.
@codecov-io
Copy link

codecov-io commented Oct 18, 2018

Codecov Report

Merging #501 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #501      +/-   ##
============================================
+ Coverage     99.38%   99.38%   +<.01%     
- Complexity     1260     1261       +1     
============================================
  Files           217      217              
  Lines          4070     4072       +2     
  Branches        213      214       +1     
============================================
+ Hits           4045     4047       +2     
  Misses            5        5              
  Partials         20       20
Impacted Files Coverage Δ Complexity Δ
...quorum/tessera/transaction/PayloadEncoderImpl.java 98.93% <100%> (+0.02%) 11 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b2053...438cc59. Read the comment docs.

@Krish1979 Krish1979 merged commit 86e2001 into Consensys:master Oct 22, 2018
@Krish1979 Krish1979 deleted the update-payload-decoding branch October 22, 2018 11:33
@prd-fox prd-fox added bug Something isn't working 0.7 labels Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.7 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants