Fix #705 out of memory error thrown by Files.readAllBytes #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for set binary stream when available to JDBC driver. Fixes #705 where Files.readAllBytes throws out of memory error. Conflicts: data-migration/src/test/java/com/quorum/tessera/data/migration/DirectoryStoreFileTest.java
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
============================================
+ Coverage 99.49% 99.49% +<.01%
- Complexity 1867 1874 +7
============================================
Files 285 286 +1
Lines 5552 5572 +20
Branches 278 281 +3
============================================
+ Hits 5524 5544 +20
Misses 5 5
Partials 23 23
Continue to review full report at Codecov.
|
Avoid Files max size validation to ensure buffering is working. Same test fails with same messageless error reported by user against master.
Krish1979
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change data loaders to return input streams rather than byte arrays.