handle supercall and modifier args for semantic decoration (#117)

* handle supercall and modifier args for semantic deco

* update changelog

CHANGELOG.md

@@ -14,6 +14,7 @@ Note: Don't forget to check out `preferences → Settings → Solidity Visual De
   - clicking on a function name highlights the first line of the function instead of the full function block in the editor
   - clicking on an external call/modifier highlights the invocation in the editor
 
+- fix: semantic highlighting for supercall and modifier arguments - #112 #117
 
 ## v0.1.3
 - new: customize semantic highlighting mode #105 #108

package.json

@@ -541,7 +541,7 @@
     "dependencies": {
         "c3-linearization": "^0.3.0",
         "keccak": "^3.0.2",
-        "solidity-workspace": "^0.1.6",
+        "solidity-workspace": "^0.1.7",
         "surya": "^0.4.6"
     }
 }

src/extension.js

@@ -259,6 +259,7 @@ function analyzeSourceUnit(cancellationToken, document, editor) {
                                 // local declaration
                                 switch (ident.extra.scope) {
                                     case "argument":
+                                    case "super":
                                         highlightIdentifiers.push(ident);
                                         break;
                                     case "returns":

src/features/deco.js

@@ -194,14 +194,18 @@ var gutterIcons = {};
 
 
 function varDecIsArray(node) {
-    return node.typeName.type == "ArrayTypeName";
+    return node && node.typeName && node.typeName.type == "ArrayTypeName";
 }
 
 function varDecIsUserDefined(node) {
-    return node.typeName.type == "UserDefinedTypeName";
+    return node && node.typeName && node.typeName.type == "UserDefinedTypeName";
 }
 
 function getVariableDeclarationType(node) {
+    if(!node){
+        return null;
+    }
+
     if (typeof node.typeName != "undefined" && node.typeName != null) {
         if (varDecIsArray(node)) {
             node = node.typeName.baseTypeName;

src/features/whatsnew/whatsNew.js

@@ -49,6 +49,7 @@ The complete changelog can be found [here](https://github.com/ConsenSys/vscode-s
   - clicking on a function name highlights the first line of the function instead of the full function block in the editor
   - clicking on an external call/modifier highlights the invocation in the editor
 
+- fix: semantic highlighting for supercall and modifier arguments - #112 #117
 
 ## v0.1.3 - 🧸