Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate vertx pool size options #947

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Validate vertx pool size options #947

merged 2 commits into from
Nov 9, 2023

Conversation

usmansaleem
Copy link
Contributor

PR Description

Validate vertx pool size options. The deprecated worker pool size and new vertx worker pool size cli options are mutually exclusive.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@usmansaleem
Validate vertx pool size options
cec6a97 
 -- the deprecated worker pool size and new vertx worker pool size cli options are mutually exclusive.
@usmansaleem
refactor getter
b2635c7
jframe
jframe approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

siladu
siladu approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem merged commit 4db92ab into Consensys:master Nov 9, 2023
7 checks passed
@usmansaleem usmansaleem deleted the validate_vertx_worker_cli_option branch November 9, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@usmansaleem @jframe @siladu