Hide notes if no notes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than displaying an empty notes box, this hides the notes box completely if there are no notes.
|
Does this make the right column work as intended? I haven't tested it but if it works the same way I will accept it :3 can you post a screen? rather busy atm. Thanks! |
|
Sorry for the delay, seems I didn't get the notification for this... Yes because notes was position absolute and the right column has a margin-left, the position is left unchanged. Here's how it looks:
|
|
I'm also sorry, did not check it myself either. Seems good to go! |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than displaying an empty notes box, this hides the notes box completely if there are no notes.
Let me know what you think!