Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Laravel 9 #80

Closed
wants to merge 4 commits into from
Closed

Conversation

jkudish
Copy link
Contributor

@jkudish jkudish commented Mar 15, 2022

Add support for Laravel 9 and removes explicit dependency on illuminate packages which were replaced by laravel/framework.

Should be a major version bump to avoid issues with older versions

@jkudish jkudish mentioned this pull request Mar 15, 2022
@ConsoleTVs
Copy link
Owner

That's not how it works. You're adding a whole new bunch of dependencies for the shake of doing. Those two illuminate dependencies have not been replaced whatsoever.

@ConsoleTVs ConsoleTVs closed this Mar 16, 2022
@jkudish
Copy link
Contributor Author

jkudish commented Mar 16, 2022

Hi @ConsoleTVs

Ok, I hear you, this was the way I was able to get composer to actually install it and it does still work with Laravel 9. I couldn't get illuminate/view to work standalone -- I kept getting a composer error about needing to use laravel/framework instead. It's totally possible that I missed something.

If you have other suggestions on how to make your package work with Laravel 9, I'd be happy to contribute it if you don't have the time to work on it yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants