Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export pem in pkcs8 to relax Chrome WebStore #13

Merged
merged 1 commit into from
Jul 26, 2013
Merged

export pem in pkcs8 to relax Chrome WebStore #13

merged 1 commit into from
Jul 26, 2013

Conversation

cielavenir
Copy link
Contributor

Somehow Chrome WebStore started to deny pkcs1 key, so let's export pkcs8 instead

@Constellation
Copy link
Owner

LGTM, merging. Thanks!

Constellation added a commit that referenced this pull request Jul 26, 2013
@Constellation
Merge pull request #13 from cielavenir/master
bd9600d 
export pem in pkcs8 to relax Chrome WebStore
@Constellation Constellation merged commit bd9600d into Constellation:master Jul 26, 2013
@cielavenir
Copy link
Contributor Author

Oh thank you.
But... is it alright?
For example, there are no ways to suppress the warning on jruby because openssl_pkcs8 uses ext.
So perhaps

if defined?($pkcs8_warning)&&@verbose

is better? I'd like your opinion.

@Constellation
Copy link
Owner

Ah, thanks.
Hmm, I've got it. Using @verbose looks better.
Could you create another pull request for this?

@cielavenir cielavenir mentioned this pull request Dec 30, 2013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cielavenir @Constellation