Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of geo_location field in record resources (proposal uses TypeSet) #14

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

coxjonc
Copy link
Contributor

@coxjonc coxjonc commented Oct 7, 2020

Similar to #11, but uses TypeSet instead of TypeMap. This is correct for schemas that require predefined keys. It will break existing HCL configuration that sets geolocation using the old map syntax. Note the missing = below.

geo_location = {
    geo_ip_proximity = xxxxx
    geo_ip_failover  = xxxx
  }

would need to be converted to

geo_location {
    geo_ip_proximity = xxxxx
    geo_ip_failover  = xxxx
  }

The provider will also break if it attempts to import state that has stored geolocation as a Map rather than a Set. State will need to be removed and re-imported.

The changes have only been applied to a records and cname records because these are the records we use. I think the same problem is present in other record types - not sure, haven't checked. May be worth fixing those later.

@coxjonc coxjonc changed the title Set Fix parsing of geo_location field in record resources (proposal uses TypeSet) Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants