Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties in BankingTransactionDetail objects #414

Closed
nils-work opened this issue Oct 21, 2021 · 3 comments
Closed

Properties in BankingTransactionDetail objects #414

nils-work opened this issue Oct 21, 2021 · 3 comments
Labels
Banking Banking domain APIs Proposal made The DSB has proposed a specific change to the standards to address the change request
Projects
Data Standards Maintenance

Comments

@nils-work
Copy link
Member

nils-work commented Oct 21, 2021 •
edited by CDR-API-Stream
Loading

Description

The swagger JSON and the documentation of properties in the BankingTransactionDetail schema seem to be misaligned.

Area Affected

BankingTransactionDetail extendedData schema documentation and related Swagger objects.

Change Proposed

The extendedDescription property shows as x-conditional in the BankingTransactionDetail_extendedData object (but it's not present there), and also shows as required in the BankingTransactionDetail_extendedData_x2p101Payload object (where the property is actually present).

The standards documentation shows that field as mandatory, but the Description includes a condition -
An extended string description. Only present if specified by the extensionUType field

image

Can these details be clarified?

image

DSB Proposed Solution

The current DSB proposal for this issue is in this comment
@CDR-API-Stream CDR-API-Stream added Banking Banking domain APIs In Backlog labels Feb 10, 2022
@CDR-API-Stream CDR-API-Stream added this to Full Backlog in Data Standards Maintenance via automation Feb 10, 2022
@elizabetharnold elizabetharnold moved this from Full Backlog to Iteration Candidates in Data Standards Maintenance Jul 28, 2022
@CDR-API-Stream CDR-API-Stream mentioned this issue Aug 1, 2022
Closed
@CDR-API-Stream
Copy link
Collaborator

This appears to be a defect and it is proposed that it is simply fixed according to the Change Proposed section of the issue.

@CDR-API-Stream CDR-API-Stream added the Proposal made The DSB has proposed a specific change to the standards to address the change request label Aug 17, 2022
@CDR-API-Stream CDR-API-Stream moved this from Iteration Candidates to In Progress: Design in Data Standards Maintenance Aug 17, 2022
@CDR-API-Stream
Copy link
Collaborator

This change has been staged for review: ConsumerDataStandardsAustralia/standards-staging@release/1.19.0...maintenance/414

@CDR-API-Stream CDR-API-Stream moved this from In Progress: Design to In Progress: Staging in Data Standards Maintenance Aug 30, 2022
@CDR-API-Stream
Copy link
Collaborator

This change has been updated to target v1.20.0: ConsumerDataStandardsAustralia/standards-staging@release/1.20.0...maintenance/414

@markverstege markverstege mentioned this issue Nov 2, 2022
Merged
@JamesMBligh JamesMBligh moved this from In Progress: Staging to Awaiting Chair Approval in Data Standards Maintenance Dec 14, 2022
@JamesMBligh JamesMBligh moved this from Awaiting Chair Approval to Done in Data Standards Maintenance Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Banking Banking domain APIs Proposal made The DSB has proposed a specific change to the standards to address the change request
Projects
Data Standards Maintenance
Archived in project
Data Standards Maintenance
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JamesMBligh @CDR-API-Stream @nils-work