Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration 13 Holistic Feedback #551

Closed
CDR-API-Stream opened this issue Oct 20, 2022 · 12 comments
Closed

Iteration 13 Holistic Feedback #551

CDR-API-Stream opened this issue Oct 20, 2022 · 12 comments
Labels
Documentation Improvements, additions or queries related to documentation

Comments

@CDR-API-Stream
Copy link
Collaborator

CDR-API-Stream commented Oct 20, 2022

This CR has been created to simplify the raising of minor changes, such as text corrections or description clarifications, that are not really material to the standards but do have real impact of readability and clarity.

Please raise any such suggestions that you would like included in Maintenance Iteration 13 and the DSB will review them. If we believe the suggestion are material we will raise a dedicated CR for them.

@CDR-API-Stream CDR-API-Stream added this to Full Backlog in Data Standards Maintenance via automation Oct 20, 2022
@CDR-API-Stream
Copy link
Collaborator Author

Update the description of accountCharges in EnergyInvoice to clarify that it is for account level charges and credits

image

@perlboy
Copy link

perlboy commented Oct 23, 2022

readQualities for usage is being described as an Object when it isn't:
image

This should be an array of objects because it is possible for there to be multiple sets of read qualities over a sampling period.

@nils-work
Copy link
Member

A missing font reference appears to have some impact on the Standards page rendering time.
Detail is in ConsumerDataStandardsAustralia/standards-staging#235

@nils-work
Copy link
Member

Two broken links in Register APIs documentation
ConsumerDataStandardsAustralia/standards-staging#234

@nils-work
Copy link
Member

nils-work commented Oct 26, 2022

The first sentence in the Register APIs section of the Standards states -

This following provides an overview of the Register APIs for Data Holders and Data Recipients to collect participant metadata exclusively for the banking sector. These endpoints are exposed by the Register and consumed by Data Holders and Data Recipients.

It should be updated to -

The following section provides an overview of the Register APIs for Data Holders and Data Recipients to collect participant metadata.

@nils-work
Copy link
Member

Links referencing TDIF should be updated to the new site - https://www.digitalidentity.gov.au/tdif

@nils-work
Copy link
Member

Apart from the FDO table where some historical dates are maintained for reference, the Amending Authorisation Standards section repeats that the amending standards are Effective from November 2021.
As this is now almost 12 months past, it may be appropriate to remove this specific mention.

@nils-work
Copy link
Member

Consider extending the list of applicable endpoints in the CORS section to include the unauthenticated endpoints for Energy (and Telco?) or move the endpoint designation into the respective endpoint definitions so it doesn't need to be maintained separately.
Another alternative may be to clarify that all unauthenticated endpoints require CORS, but this may not always be the case.

@nils-work
Copy link
Member

The endpoints in the Energy Secondary DH APIs section all incorrectly state This operation does not require authentication.
These should be updated to something like This operation may only be called by Energy Primary Data Holders.

@CDR-API-Stream
Copy link
Collaborator Author

readQualities for usage is being described as an Object when it isn't: image

This should be an array of objects because it is possible for there to be multiple sets of read qualities over a sampling period.

This defect was fixed in version 1.20.0 release of the standards.

@nils-work
Copy link
Member

One additional documentation fix that may warrant late inclusion for MI13 is a typo in this statement in the Version Delta alongside HTTP Headers -
Clarified that the x-fapi-interaction-id is not required for authenticated resource APIs
It should state unauthenticated -
Clarified that the x-fapi-interaction-id is not required for unauthenticated resource APIs

@JamesMBligh JamesMBligh moved this from Full Backlog to In Progress: Staging in Data Standards Maintenance Dec 14, 2022
@nils-work
Copy link
Member

These items were delivered through ConsumerDataStandardsAustralia/standards#272 (comment)

Data Standards Maintenance automation moved this from In Progress: Staging to Done Jan 18, 2023
@nils-work nils-work added the Documentation Improvements, additions or queries related to documentation label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements, additions or queries related to documentation
Projects
Status: Done
Development

No branches or pull requests

3 participants