Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision Proposal 068 - Enhanced Error Handling #68

Closed
JamesMBligh opened this issue May 1, 2019 · 3 comments
Closed

Decision Proposal 068 - Enhanced Error Handling #68

JamesMBligh opened this issue May 1, 2019 · 3 comments
Assignees
Labels
Category: API A proposal for a decision to be made for the API Standards made Industry: Banking This proposal impacts the banking industry Industry: Electricity This proposal impacts the electricity industry sector Status: No Decision Taken No determination for this decision has been made

Comments

@JamesMBligh
Copy link
Contributor

Currently a placeholder for a decision proposal on enhanced error codes for specific API error scenarios.

@JamesMBligh JamesMBligh added Category: API A proposal for a decision to be made for the API Standards made Status: Proposal Pending A proposal for the decision is still pending labels May 1, 2019
@JamesMBligh JamesMBligh self-assigned this May 1, 2019
@kaveenr
Copy link

kaveenr commented Nov 8, 2019

Hello all,

Crosspost from ConsumerDataStandardsAustralia/standards-maintenance#36

Upon looking at the OpenAPI Schema given for the CDS v1 API it shows that the current error model ResponseErrorList_errors only support a single error type.

It is for the 422 Unprocessable entity exceptions of the POST calls in the API, this is further justified with the description Must be one of the following: 0001 – Account not able to be found.

Any considerations for introducing different error codes for HTTP bad request, Internal Server Error, etc?
With this, we are able to give textual descriptions in case of a missing attribute bad request as an example.

If only a single type of code is allowed why not make the OpenAPI schema code attribute an enumeration?

In the case of a GET request to /banking/accounts/{accountId} with an invalid accountID can the same 0001 – Account not able to be found be used as a response?

Cheers,

@CDR-API-Stream
Copy link
Contributor

Hi all, further to the feedback received so far on this issue, the DSB has received constructive input on explicit error handling from the Bendigo & Adelaide Bank.

Error Handling Scenarios - Bendigo & Adelaide Bank.April 2020.pdf

@CDR-API-Stream
Copy link
Contributor

This placeholder has been subsumed by the ongoing error handling consultations and will now be closed.

@CDR-API-Stream CDR-API-Stream added Status: No Decision Taken No determination for this decision has been made and removed Status: Proposal Pending A proposal for the decision is still pending labels Jan 23, 2021
JamesMBligh pushed a commit that referenced this issue Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: API A proposal for a decision to be made for the API Standards made Industry: Banking This proposal impacts the banking industry Industry: Electricity This proposal impacts the electricity industry sector Status: No Decision Taken No determination for this decision has been made
Projects
None yet
Development

No branches or pull requests

3 participants