fix: remove errors replace of null (#127)

src/creditcard.js

@@ -30,6 +30,7 @@ export const isValid = (number) => {
 };
 
 function findCreditCardObjectByNumber(number) {
+  if (!number) return {};
   const numberOnly = number.replace(/[^\d]/g, '');
   return CARDS.find((card) => card.bins.test(numberOnly) && card) || {};
 }

src/creditcard.test.js

@@ -67,6 +67,18 @@ describe('CreditCard', () => {
     it('should return false when month is past', () => {
       expect(isExpirationDateValid('01', '2017')).toBe(false);
     });
+
+    it('should return false when send zero value', () => {
+      expect(isExpirationDateValid(0, 0)).toBe(false);
+    });
+
+    it('should return false when null values', () => {
+      expect(isExpirationDateValid(null, null)).toBe(false);
+    });
+
+    it('should return false when send no params', () => {
+      expect(isExpirationDateValid()).toBe(false);
+    });
   });
 
   describe('#isSecurityCodeValid', () => {
@@ -101,6 +113,18 @@ describe('CreditCard', () => {
     it('should return false when its a not mapped card type and security code has not 3 digit', () => {
       expect(isSecurityCodeValid('123', '99')).toBe(false);
     });
+
+    it('should return false when send empty params', () => {
+      expect(isSecurityCodeValid('', '')).toBe(false);
+    });
+
+    it('should return false when send no params', () => {
+      expect(isSecurityCodeValid()).toBe(false);
+    });
+
+    it('should return false when send null params', () => {
+      expect(isSecurityCodeValid(null, null)).toBe(false);
+    });
   });
 
   describe('#getCreditCardNameByNumber', () => {
@@ -140,11 +164,25 @@ describe('CreditCard', () => {
       expect(getCreditCardNameByNumber(CREDIT_CARDS.visaMask)).toBe('Visa');
     });
 
-    it('should return false', () => {
+    it('should return false when card number is invalid', () => {
       expect(getCreditCardNameByNumber(INVALID_CREDIT_CARD)).toBe(
         'Credit card is invalid!'
       );
     });
+
+    it('should return false when send no params', () => {
+      expect(getCreditCardNameByNumber()).toBe('Credit card is invalid!');
+    });
+
+    it('should return false when send empty params', () => {
+      expect(getCreditCardNameByNumber('', '')).toBe('Credit card is invalid!');
+    });
+
+    it('should return false when send null params', () => {
+      expect(getCreditCardNameByNumber(null, null)).toBe(
+        'Credit card is invalid!'
+      );
+    });
   });
 
   describe('#validate', () => {