Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/charge patterns #27

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Feat/charge patterns #27

wants to merge 11 commits into from

Conversation

yzuuang
Copy link

@yzuuang yzuuang commented Nov 10, 2020

Electrostatic with potential, gradient and curvature.

Adhesion/Interactions/Electrostatic.py Show resolved Hide resolved
Adhesion/Interactions/Electrostatic.py Outdated Show resolved Hide resolved
def __repr__(self, ):
return ("Potential '{0.name}': ε = {0.eps}, σ = {0.sig}").format(self)

def evaluate(self,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this computes the net force caused by the charge patterns, right ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the functions "evaluate"? it calculate both potential, gradient(adhesion stress) and curvature.

Copy link
Author

@yzuuang yzuuang Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the repr needs a better description

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean Force vs. spacially resolved pressure

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pressure.

test/Interactions/test_electrostatic.py Outdated Show resolved Hide resolved
test/Interactions/test_electrostatic.py Outdated Show resolved Hide resolved
test/Interactions/test_electrostatic.py Outdated Show resolved Hide resolved
test/Interactions/test_electrostatic.py Outdated Show resolved Hide resolved
test/Interactions/test_electrostatic.py Outdated Show resolved Hide resolved
@sannant
Copy link
Collaborator

sannant commented Nov 11, 2020

You implemented the net force and it's potential and derivative.

I think you at least also have the stress distribution at least in overleaf. Can you also implement this ?

I think we discussed that the derivative and potential to the stress field according to the gap field is more tricky.

@sannant
Copy link
Collaborator

sannant commented Nov 11, 2020

implements #26

@yzuuang
Copy link
Author

yzuuang commented Nov 20, 2020

You implemented the net force and it's potential and derivative.

I think you at least also have the stress distribution at least in overleaf. Can you also implement this ?

I think we discussed that the derivative and potential to the stress field according to the gap field is more tricky.

Do you mean the stress distribution in space? i.e. change of stress according to the space distance z rather than gap distance d?

@sannant
Copy link
Collaborator

sannant commented Nov 20, 2020

I mean pressure as a function of x and y

@yzuuang
Copy link
Author

yzuuang commented Nov 20, 2020

of x and y

OK I got it. But actually in general cases, a function of x and y is not really possible. Or should I just integral back from Fourier space to compute E-field? Then it will be a variation to the original Persson's method.

@sannant
Copy link
Collaborator

sannant commented Nov 21, 2020

I guess you can only compute sigma(x, y) from the realspace electric field yes.

@sannant
Copy link
Collaborator

sannant commented Jan 22, 2023

@sitangshugk95 I merged master in the code and the tests pass without bug. However, some tests need to be improved to add checks of the accuracy of the results. I opened an issue for that.

@pastewka
Copy link
Contributor

@sannant - what do we do with this?

@sannant
Copy link
Collaborator

sannant commented Jun 18, 2023

I would keep it like that until someone eventually follows up on the work (which might be forever ).

But I am happy to help out (we have quite detailed latex notes on the derivation of the formulas) if someday someone takes over.

@pastewka
Copy link
Contributor

Okay sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants