Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook For Teardown #486

Open
logston opened this issue Jun 21, 2023 · 1 comment · May be fixed by #567
Open

Webhook For Teardown #486

logston opened this issue Jun 21, 2023 · 1 comment · May be fixed by #567

Comments

@logston
Copy link

logston commented Jun 21, 2023

Please describe what you would like to see in ContainerSSH

Currently ContainerSSH provides a webhook for authentication and configuration of a container (or pod) that are triggered by an SSH connection to the ContainerSSH server. Upon successful authentication, the container described by the configuration is instantiated. Upon SSH disconnect, the container is removed by the server.

We would like a third webhook which would receive the status of the removal.

Please describe your use case

In order to run a ConatinerSSH created container successfully in a k8s environment, we choose to spin up auxiliary services (VMs, pods, etc). We would like some signal to know when we can tear down those extra resources.

@janosdebugs
Copy link
Contributor

Hey @logston this is great idea and should be fairly simple to implement. However, we currently don't have capacity to add additional features. If you or anyone else would be willing to implement this, we'd be more than happy to review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants