WIP: cre technical patterns #9
Conversation
Ottovsky
requested review from
cewood,
rodrmartinez,
elieser1101 and
darren-reddick
|
Could we put a guide on running this locally? I've been running jekyll locally and its nice to have the option to see the changes rendered. |
Maybe we could target migrating this to Hugo later on as well, if anyone is interested? There's no reason to be migrating sites to Jekyll in 2020, just more cargo culting 🤦♂️ |
Yes. That could be a good thing to do. |
Kewl, well we can add an item to our backlog if there's interest to track doing that later.
It's being published to GitHub pages, the hint is here https://github.com/ContainerSolutions/cloud-native-patterns/blob/master/CNAME That could also be something we considering changing, moving it to Netlify or similar, so we can get viewable deployment previews on PR's, to properly see things before merging or releasing, etc. I've had great success using Cloudflare, Netlify, and Hugo before, super fast free hosting and nice experience overall. |
I like the idea, I will create a low priority task in the jira for it. |
|
|
||
| CI/CD services on an Enterprise scale are difficult to implement. Taking into account | ||
| requirements for auditing, compliance and team flexibility will lead to a system | ||
| which is customized to a high degree. Often the responsibility for the these services | ||
| end up with the Platform Team, which is managing infrastructure. While CI/CD is related | ||
| to the infrastructure platform, it has it's own goals and a different domain (in DDD terms). | ||
|
|
||
| ## Solution | ||
| ## Therefore | ||
|
|
||
| Create a dedicated product team, which will build and manage CI/CD services. This team will |
There was a problem hiding this comment.
Having the word "product" here is confusing. Would it not read better if it just said "create a dedicated team" as a reference to the CI/CD Platfrom team.
There was a problem hiding this comment.
You are right, without defining what does the "product team" means, we should not use it here.
_technical/gitops.md
Outdated
| layout: pattern | ||
| --- | ||
|
|
||
|  | ||
|
|
||
| Description part 2 | ||
| You have setup all your infrastructure as code (see #InfrastructureAsCode pattern). |
There was a problem hiding this comment.
I dont see an InfrastructureAsCode pattern anywhere in this repo. I am going to remove this reference for now....
|
Im not sold on the "structured-logging" pattern - i'm not sure what it is advocating: is it the centralization of the logs? Is it a particular format for the logs? Of course these are good things but I dont think the case for them is well presented here. |
|
Agree, I was not bought by this when I refactored it. I think it is about having logs structured and serialized in a way that it is easy to store and query in ELK or something similar. The reference to the RFC is not very clear to me, I would just drop it for now. |
Here you go.... https://container-solutions.atlassian.net/wiki/spaces/CRE/pages/263356540/Tech+Patterns+Cloud+Native+Patterns+Discussion |
Co-authored-by: Cameron Wood <cameron.wood@container-solutions.com>
There was a problem hiding this comment.
LGTM 👍
@darren-reddick can you please review and merge if there's no further feedback.
|
Have run it using a jekyll server locally and LGTM |
Please treat it as an invitation to the discussion in comments, I think there is still some work to be done before merging.
Let's agree whether those patterns fit the CRE idea and we could possibly support them in the future. Also if you have any comments regarding content, formatting, typos, please don't hesitate to raise them.