Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] Boolean should be compared strictly - in modules/ModuleDlstatsStatistics.php, line 143 #66

Closed
BugBuster1701 opened this issue Mar 4, 2015 · 0 comments

Comments

@BugBuster1701
Copy link
Collaborator

in modules/ModuleDlstatsStatistics.php, line 143

With booleans, only strict comparison (with === operator) should be used to lower bug risks and to improve performances.

     * @return string
     */
    protected function getStatusCounting()
    {
        if ( isset($GLOBALS['TL_CONFIG']['dlstats']) 
                && $GLOBALS['TL_CONFIG']['dlstats'] == true  
           ) 
        {
            return '<span class="tl_green">'.$GLOBALS['TL_LANG']['tl_dlstatstatistics_stat']['status_activated'].'</span>';
        }
        return '<span class="tl_red">'.$GLOBALS['TL_LANG']['tl_dlstatstatistics_stat']['status_deactivated'].'</span>';

Posted from SensioLabsInsight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant