Feat/query retry #242
Merged
Feat/query retry #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingmaoYou
force-pushed
the
feat/query_retry
branch
from
2b8a534
to
9780610
Compare
JingmaoYou
commented
Oct 11, 2022
There was a problem hiding this comment.
Have you tested it in your local environment? It'd be nice if we could validate it with following topology:
- shard1-r1
- shard1-r2
- shard2-r1
- shard2-r2
and two strategies: - you kill one of the nodes and make sure the retry strategy works correctly when the queried node was the dead one (you may want to disable heartbeat's otherwise it'll be hard)
- you kill both replicas of shard 1 for instance. Query should be refused
config/config.go
Outdated
| @@ -342,6 +345,9 @@ type Cluster struct { | |||
|
|
|||
| // Catches all undefined fields | |||
| XXX map[string]interface{} `yaml:",inline"` | |||
|
|
|||
| // Retry number for query - how many times a query can retry after bad gateway response from the host | |||
| RetryNumber int `yaml:"retrynumber"` | |||
There was a problem hiding this comment.
to stay consistent with other fields and omit empty values
Suggested change
| RetryNumber int `yaml:"retrynumber"` | |
| RetryNumber int `yaml:"retry_number",omitempty` |
JingmaoYou
commented
Oct 31, 2022
| @@ -203,16 +203,17 @@ func executeWithRetry( | |||
| respondWith(srw, err1, srw.StatusCode()) | |||
| return since, nil | |||
| } else { | |||
| h := s.host | |||
| h.dec() | |||
| atomic.StoreUint32(&h.active, uint32(0)) | |||
There was a problem hiding this comment.
I have checked the load-balancer argo, we need to penalise the host when the query failed. Including the query that we want to retry.
JingmaoYou
commented
Oct 31, 2022
| req.URL.Scheme = s.host.addr.Scheme | ||
| log.Debugf("the valid host is: %s", s.host.addr) | ||
| } | ||
|
|
There was a problem hiding this comment.
As discussed, this if condition is not required in the real production env.
gontarzpawel
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #185
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
Further comments