Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Redis password in info logs when redis username is empty #399

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Hide Redis password in info logs when redis username is empty #399

merged 1 commit into from
Feb 14, 2024

Conversation

smunukutla-mycarrier
Copy link
Contributor

@smunukutla-mycarrier smunukutla-mycarrier commented Feb 11, 2024 •
edited

Description

Hide Redis password in info logs when redis username is empty in chproxy config

Pull request type

Implements #398

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

@smunukutla-mycarrier smunukutla-mycarrier marked this pull request as ready for review February 11, 2024 23:05
@mga-chka mga-chka merged commit f4daa21 into ContentSquare:master Feb 14, 2024
4 of 5 checks passed
@mga-chka
Copy link
Collaborator

FYI, we should release a new version before then end of the month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mga-chka mga-chka mga-chka approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smunukutla-mycarrier @mga-chka