Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the linter work again #419

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

Scartiloffista
Copy link
Collaborator

@Scartiloffista Scartiloffista commented Apr 4, 2024

Description

the title says it all. fixes #418

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

Copy link

render bot commented Apr 4, 2024

@Scartiloffista Scartiloffista changed the title first test fix: make the linter work again Apr 4, 2024
@Scartiloffista Scartiloffista force-pushed the make_linter_great_again branch 2 times, most recently from d01ce41 to 3e50137 Compare April 4, 2024 09:30
@Scartiloffista Scartiloffista marked this pull request as ready for review April 4, 2024 09:33
@@ -28,7 +28,7 @@ run: build

lint:
go vet $(pkgs)
go list ./... | grep -v /vendor/ | xargs -n1 golint
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecated and also not the one we use in the GHA

Copy link
Collaborator

@mga-chka mga-chka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Scartiloffista Scartiloffista merged commit da81a55 into master Apr 4, 2024
5 checks passed
Scartiloffista added a commit that referenced this pull request Apr 11, 2024
* first test

* test again
@Scartiloffista Scartiloffista deleted the make_linter_great_again branch May 28, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] fix linter issues
2 participants