Resolved issue #15 and added true iterator for efficient reading of records #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slice is costly and slow, since it has to open file and seek records for subsequent calls.
|
great work thanks @thammegowda |
chrismattmann
added a commit
that referenced
this pull request
Sep 26, 2015
Resolved issue #15 and added true iterator for efficient reading of records
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| data = nutchpy.sequence_reader.slice(5,20,path) | |||
| # print(data) | |||
| assert len(data) == 2 | |||
| assert len(data) == 3 | |||
There was a problem hiding this comment.
Why is a slice from 5 to 20 yielding a length of 3?
There was a problem hiding this comment.
Since the example data has 8 records [0..7], the slice(5, 20) function returns last three records [5,6,7].
|
This looks really good. Thanks @thammegowda |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slice()method is now properRecordIterator, a real iterator in java is added to efficiently read records( the subsequent calls toslice()has heavy disk seek overhead as it has to skip records till the start position for each call).SequenceReaderTestis added