Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] transformed incremental + Rotations & Permutations [2] #29

Merged
merged 51 commits into from
Jul 28, 2020
Merged

[WIP] transformed incremental + Rotations & Permutations [2] #29

merged 51 commits into from
Jul 28, 2020

Conversation

TLESORT
Copy link
Collaborator

@TLESORT TLESORT commented May 10, 2020

No description provided.

TLESORT added 18 commits May 2, 2020 18:21
@TLESORT
modification start for mode_incremental which is in fact trasnformati…
57e91d4 
…on_incremental
@TLESORT
it works now samples generated are now good
f2c7d5b
@TLESORT
add test for init of transform_incremental
36d9b79
@TLESORT
merge train_transformation and common_trasnformation into base_trasnf…
448d4ac 
…ormation
@TLESORT
merge train and common transformer
a01d886
@TLESORT
merge sovlved
4a02e10
@TLESORT
remove train parameter as it is not ued
ad6d535
@TLESORT
permutatations class added
1f7f54a
@TLESORT
add test for rotations
dd6b8ca
@TLESORT
new function to sample several images
b67c759
@TLESORT
update viz with new dataset parameters
2f63f95
@TLESORT
fix merge conflicts
2609008
@TLESORT
move file to clloader
8d505c2
@TLESORT
fix imports
3090097
@TLESORT
_continuumdataset object are either for test or train not both
b0459d6
@TLESORT
tests updated
4961b31
@TLESORT
update with new dataset initialisation
acfbfeb
@TLESORT
some codacy error and comments addressed
753aac2
@TLESORT TLESORT mentioned this pull request May 10, 2020
Closed
@TLESORT TLESORT mentioned this pull request Jul 16, 2020
Closed
arthurdouillard
arthurdouillard reviewed Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@arthurdouillard arthurdouillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool PR! I like it better your new transformed than my ugly initial attempt.

I've made remarks, I'm open to discussion :)

Good job! 👍

continuum/datasets/base.py Outdated Show resolved Hide resolved
continuum/datasets/base.py Outdated Show resolved Hide resolved
continuum/datasets/base.py Outdated Show resolved Hide resolved
continuum/datasets/base.py Outdated Show resolved Hide resolved
continuum/datasets/base.py Outdated Show resolved Hide resolved
continuum/task_set.py Show resolved Hide resolved
tests/test_permutations.py Outdated Show resolved Hide resolved
tests/test_rotations.py Show resolved Hide resolved
tests/test_transformation_incremental.py Show resolved Hide resolved
tests/test_visualization.py Show resolved Hide resolved
TLESORT
TLESORT commented Jul 28, 2020
View reviewed changes
tests/test_taskset.py Outdated Show resolved Hide resolved
@TLESORT
remove duplicated code
ae877eb
@TLESORT
move super call in first place in init function
7447cf3
@TLESORT
train parameter transmitted to super class
0f56574
@TLESORT
we impose __getitem__ to return a tensor
8a7c00e
@TLESORT
test get_raw_samples_from_ind function from task_set
6f09402
@TLESORT
we apply ToTensor transformation only if type is not already torch.te…
b1dccfc 
…nsor
@TLESORT
test that use real datasets are marked as slow and are not runned by …
400ba26 
…default by travis
@TLESORT
update readme for pytests
7f445f5
@TLESORT
travis config changed
d638d41
@TLESORT
we test now that the permutation is done and compare with manual perm…
735adca 
…utation with same seed
@TLESORT
we test if bad data as input generate an assert error
36de992
@TLESORT
code reformated
0b0cd80
@TLESORT
remplace xfail mark by with pytest.raises(...):, this approach should…
7f8a20f 
… be privilegied in the future
@TLESORT
test for transformation improved, we check the transformation is done…
4772377 
… correctly
@TLESORT TLESORT merged commit 2d40c7a into master Jul 28, 2020
This was referenced Jul 28, 2020
Closed
Closed
Closed
Closed
Closed
@arthurdouillard arthurdouillard mentioned this pull request Aug 14, 2020
Closed
@TLESORT TLESORT deleted the transf_inc branch September 1, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurdouillard arthurdouillard arthurdouillard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TLESORT @arthurdouillard