Fixes missing support for file names containing hyphens, closes #1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hollodotme
commented
Oct 15, 2017
hollodotme
commented
- Uses PHP's getopt() to retrieve CLI options
- Replaces '/' with DIRECTORY_SEPARATOR constant
- Fixes trailing slash in output dir path
- Removes public member $free_values
- Changes visibility of members $args and $input_files to private
- Adds getter for input files
…rtio#1 * Uses PHP's getopt() to retrieve CLI options * Replaces '/' with DIRECTORY_SEPARATOR constant * Fixes trailing slash in output dir path * Removes public member $free_values * Changes visibility of members $args and $input_files to private * Adds getter for input files
|
Hi there @Dantist . Any chance this PR will be reviewed and merged? |
|
Hello, @hollodotme! Please, accept our apologies for the delay with PR merging and thank you for your great contribution! We have added some thousands of API minutes to your account as an indemnification for the inconveniences caused and as a remuneration for making our software better! :-) Feel free to contact our support team if you have accidently lost your account credentials. |
|
@Dantist no worries about the delay. Thank you for the awesome extra minutes! |
ghost
mentioned this pull request
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.