Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #733 #736

Merged
merged 1 commit into from
Nov 6, 2019
Merged

fixes #733 #736

merged 1 commit into from
Nov 6, 2019

Conversation

jackhenry
Copy link
Contributor

Proposed change ensures controls property is always set to true if isChannel regex check on twitch url is true.

controls property for twitch player must be true if url is for a channel. Otherwise, video will not load in iframe.
@jackhenry
Copy link
Contributor Author

Also, this fixes test 3 for the twitch player on the React-Player demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants