Skip to content

Commit

Permalink
Added a notification for FPI=true and FF version=58
Browse files Browse the repository at this point in the history
  • Loading branch information
ke-d committed Jan 23, 2018
1 parent db54f00 commit 9e067a9
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/background.js
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,14 @@ const onStartUp = async () => {
key: "firstPartyIsolateSetting", value: setting.value
}
});
if (browserVersion === "58" && setting.value) {
browser.notifications.create("FPI_NOTIFICATION", {
"type": "basic",
"iconUrl": browser.extension.getURL("icons/icon_48.png"),
"title": "First Party Isolation Detected",
"message": "Please turn off privacy.firstparty.isolate and restart the browser as it breaks cookie cleanup"
});
}
}
}
// Store which browser environment in cache
Expand Down
10 changes: 10 additions & 0 deletions src/redux/Actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,16 @@ export const cookieCleanup = (options) => async (dispatch, getState) => {
greyCleanup: false, ignoreOpenTabs: false
};
}

if (getState().cache.browserVersion === "58" && getState().cache.firstPartyIsolateSetting) {
browser.notifications.create("FPI_NOTIFICATION", {
"type": "basic",
"iconUrl": browser.extension.getURL("icons/icon_48.png"),
"title": "First Party Isolation Detected",
"message": "Please turn off privacy.firstparty.isolate and restart the browser as it breaks cookie cleanup"
});
}

const cleanupDoneObject = await cleanCookiesOperation(getState(), newOptions);
const {
recentlyCleaned, setOfDeletedDomainCookies
Expand Down

0 comments on commit 9e067a9

Please sign in to comment.