Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Automatic cleaning stopped working since 3.1.0 (Chrome only) #658

Closed
antoinelibert opened this issue Mar 18, 2020 · 16 comments · Fixed by #659
Closed

[BUG] Automatic cleaning stopped working since 3.1.0 (Chrome only) #658

antoinelibert opened this issue Mar 18, 2020 · 16 comments · Fixed by #659
Labels
bug Verified Bugs

Comments

@antoinelibert
Copy link

Describe the bug

Since updating to 3.1.0, cleaning is no more triggered automatically. This is happening on my Chrome but not Firefox. Manual cleaning (click on the button) still works.

To Reproduce

Steps to reproduce the behavior:

  1. Enable automatic cleaning
  2. Set interval to 60 secs (example)
  3. Open website (not white listed)
  4. Close website tab.
  5. Wait 60 secs
  6. Cleaning is not triggered. (No new line appears in the list inside the extension popup)

Expected behavior

Cookies of [insert_website] are removed and listed in the extension popup.

Your System Info (please complete the following information):

  • OS: Windows 10 Pro 1909
  • Browser Info: Chrome 80.0.3987.149
  • CookieAutoDelete Version 3.1.0
@antoinelibert antoinelibert added the untested bug/issue Issues that have yet to be tested as per instructions label Mar 18, 2020
@bluzeman7
Copy link

Same exact issue on chromebook, latest OS, with the updated CAD 3.1.0
Was working perfectly through late last night under previous version.

@kennethtran93 kennethtran93 added bug Verified Bugs and removed untested bug/issue Issues that have yet to be tested as per instructions labels Mar 18, 2020
@kennethtran93
Copy link
Member

Whoops. I'll need to dig deeper into webextension-polyfill to see what happened between v0.1.1. and v0.6.0.

@drb-germany
Copy link

I can confirm the behavior, I have removed and reinstalled the extension (Chrome), cookies are not deleted after closing tabs even though they are supposed to be removed after 5 seconds. Last cleaning actions in log file are listed from yesterday, 2020/03/17

@kennethtran93 kennethtran93 pinned this issue Mar 18, 2020
@NooNameR
Copy link

confirmed. it is just cleaning a cookies when browser has been restarted.

@kennethtran93
Copy link
Member

Just want to make sure here so I can narrow it down: Automatic cleaning is not working after domain change or tab close, but is working on browser restart?

@NooNameR
Copy link

NooNameR commented Mar 19, 2020

yeap, correct. browser restart helps (I have disabled default browser cleanup)

@antoinelibert
Copy link
Author

I can confirm that restarting the browser triggers a cleaning.

@pacopepepipo
Copy link

Same here

It doesn't work when I hit clean manually
It doesn't work automatically
but it seems to work after restart

@drb-germany
Copy link

drb-germany commented Mar 19, 2020

It doesn't work when I hit clean manually
It doesn't work automatically
but it seems to work after restart

For me it does work when I hit clean manually!

kennethtran93 added a commit that referenced this issue Mar 20, 2020
…659)

* This fixes the Auto Cleaning function in Google Chrome (Hopefully).

Added:  Welcome Page now shows up when new version is released.
Changed:  CSS Formatting in Settings Sidebar.
Fixed:  AutoCleaning Bug in Google Chrome found in 3.1.0
Updated:  Third-Party Dependencies

Closes #658 

Signed-off-by: Kenneth Tran <kennethtran93@users.noreply.github.com>
@kennethtran93
Copy link
Member

When released, this should hopefully fix the auto cleaning in Google Chrome. Please let me know.

Seems like the alarm output changed from a way older version of Chrome WebExtension API until now...(or at least when webextension-polyfill 0.1.1 was out) to match Firefox Output

@kennethtran93 kennethtran93 unpinned this issue Mar 21, 2020
@kennethtran93 kennethtran93 pinned this issue Mar 21, 2020
@wavesurf432
Copy link

wavesurf432 commented Mar 22, 2020

Hello, I noticed the 3.1.1 update is only available for Firefox at the moment, not Chrome/Chromium/Brave.

I've been having the same issues with cookies not being deleted with Brave. Everything was working fine till a few days ago.

Edit: Just noticed too that cleanup logs aren't been logged with Firefox. Cookies are being deleted when checking Firefox's settings, but the cleanup logs in 3.1.1 aren't showing up.

Hope this helps.

@Telhub
Copy link

Telhub commented Mar 22, 2020

Additional remark:
cpu load jumps immediately to 100% when the program icon is clicked and remains there until the Google Chrome Helper (Renderer) process is killed manually.
Chrome Version 80.0.3987.149 macOS High Sierra 10.13.2

add-on worked perfectly prior to the update to 3.1.0
looking forward to the fix, thanks a lot for you work!

@kennethtran93
Copy link
Member

kennethtran93 commented Mar 22, 2020

@wavesurf432

Hello, I noticed the 3.1.1 update is only available for Firefox at the moment, not Chrome/Chromium/Brave.

I did push out the update the same time as Firefox. It appears that Google Chrome still has the update under review. Once it passed their review then it will be published to the public. If you want to temporarily install the updated version then has over to the GitHub Releases section.

I've been having the same issues with cookies not being deleted with Brave. Everything was working fine till a few days ago.

While we don't officially support variant browsers, 3.1.0 did break the auto cleanup in Chrome. 3.1.1 should fix it... Whenever it has been reviewed.

Edit: Just noticed too that cleanup logs aren't been logged with Firefox. Cookies are being deleted when checking Firefox's settings, but the cleanup logs in 3.1.1 aren't showing up.

Please open another issue for this with further details.

Thanks.

@kennethtran93
Copy link
Member

@Telhub

Additional remark:
cpu load jumps immediately to 100% when the program icon is clicked and remains there until the Google Chrome Helper (Renderer) process is killed manually.
Chrome Version 80.0.3987.149 macOS High Sierra 10.13.2

Please open a new issue for this with further details.

add-on worked perfectly prior to the update to 3.1.0
looking forward to the fix, thanks a lot for you work!

Thanks!

@wavesurf432
Copy link

@wavesurf432

Hello, I noticed the 3.1.1 update is only available for Firefox at the moment, not Chrome/Chromium/Brave.

I did push out the update the same time as Firefox. It appears that Google Chrome still has the update under review. Once it passed their review then it will be published to the public. If you want to temporarily install the updated version then has over to the GitHub Releases section.

I've been having the same issues with cookies not being deleted with Brave. Everything was working fine till a few days ago.

While we don't officially support variant browsers, 3.1.0 did break the auto cleanup in Chrome. 3.1.1 should fix it... Whenever it has been reviewed.

Edit: Just noticed too that cleanup logs aren't been logged with Firefox. Cookies are being deleted when checking Firefox's settings, but the cleanup logs in 3.1.1 aren't showing up.

Please open another issue for this with further details.

Thanks.

That's great to hear, thanks for the great extension.

@wavesurf432
Copy link

Update: everything looks to working now with the 3.1.1 update with Brave.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified Bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants