Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearing Logs delete a number of all deleted cookies. #777

Closed
Marek33 opened this issue Jun 17, 2020 · 2 comments · Fixed by #781
Closed

Clearing Logs delete a number of all deleted cookies. #777

Marek33 opened this issue Jun 17, 2020 · 2 comments · Fixed by #781
Assignees
@kennethtran93
Labels
bug Verified Bugs has:pr Issue/Feature Request has been resolved in an upcoming/merged PR
Milestone
3.5.0

Comments

@Marek33
Copy link

Marek33 commented Jun 17, 2020 •
edited

Describe the bug

Clearing Logs, shouldn't delete the number of cookies, which the Cookie AutoDelete has deleted.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Open settings'
  2. Click on 'Cleanup Log'
  3. Click on 'Clearing Logs'
  4. See that the total amount of deleted cookies is 0, instead of the number, of deleted cookies, which you had before.

Expected behavior

Clicking on Cleanup Log, and then on Clearing Logs, should remove the logs, not the total amount of deleted cookies.

Screenshots

  • OS: [Windows 7 Pro]
  • Browser Info: [Firefox 77.0.1]
  • CookieAutoDelete Version [3.3.1]

Additional context

I don't know why there is the untested bug/issue, since it's a very easily reproducible bug.
@Marek33 Marek33 added the untested bug/issue Issues that have yet to be tested as per instructions label Jun 17, 2020
@kennethtran93
Copy link
Member

Probably because not too many people visit the welcome page as it is mostly release notes and whatnot.

I'll fix the reset of cookie count, and add in a button or something to reset it from that page if users decide so.

@kennethtran93 kennethtran93 added bug Verified Bugs and removed untested bug/issue Issues that have yet to be tested as per instructions labels Jun 20, 2020
@Marek33
Copy link
Author

Marek33 commented Jun 21, 2020

I think that most people, just have a mindset where they just install it, and then don't much care for it.

That's good to hear, and I hope that it will give some kind of dialog, so it wouldn't be deleted by a mistake.

kennethtran93 added a commit that referenced this issue Jun 23, 2020
@kennethtran93
Cookie Count Stat Reset now independent of Activity Log Removals. Closes
df8b348 
 #777.

Signed-off-by: Kenneth Tran <kennethtran93@users.noreply.github.com>
@kennethtran93 kennethtran93 mentioned this issue Jun 23, 2020
Merged
@kennethtran93 kennethtran93 self-assigned this Jun 23, 2020
@kennethtran93 kennethtran93 added the has:pr Issue/Feature Request has been resolved in an upcoming/merged PR label Jun 23, 2020
kennethtran93 added a commit that referenced this issue Jun 25, 2020
@kennethtran93
Cookie Count Stat Reset now independent of Activity Log Removals. Closes
51487aa 
 #777. (#781)

Signed-off-by: Kenneth Tran <kennethtran93@users.noreply.github.com>

Co-authored-by: Kenneth Tran <kennethtran93@users.noreply.github.com>
@kennethtran93 kennethtran93 added this to the 3.5.0 milestone Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennethtran93 kennethtran93

Labels
bug Verified Bugs has:pr Issue/Feature Request has been resolved in an upcoming/merged PR
Projects
None yet
Milestone
3.5.0
2 participants
@kennethtran93 @Marek33