Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated String.prototype.substr() #1319

Merged
merged 1 commit into from Feb 27, 2022
Merged

Replace deprecated String.prototype.substr() #1319

merged 1 commit into from Feb 27, 2022

Conversation

CommanderRoot
Copy link
Contributor

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated.
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #1319 (48d6681) into 3.X.X-Branch (0fd618d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.X.X-Branch    #1319   +/-   ##
=============================================
  Coverage         47.83%   47.83%           
=============================================
  Files                34       34           
  Lines              2728     2728           
  Branches            812      812           
=============================================
  Hits               1305     1305           
  Misses             1423     1423           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fd618d...48d6681. Read the comment docs.

@github-actions
Copy link

Pull Request Build: 1872543851

Unsigned webextension builds for testing is ready for download!
These test builds are only kept for up to 90 days from the date of this post.
It is strongly recommended to use a fresh profile for testing these builds to prevent any kind of modifications to existing data.

Generating Download Links

  • /get-build for the latest commit build.
  • /get-build 1872543851 for this specific commit build.

When new command comment is posted, please allow a few seconds for the command to be received and processed.

  • 👀 indicates that command has been received.
  • 🚀 indicates that command has been sent for further processing.
  • 🎉 indicates that command has been executed. Expect a new comment with the result shortly.

Due to API limitations, generated links will only be valid for one minute!

@kennethtran93 kennethtran93 merged commit c963950 into Cookie-AutoDelete:3.X.X-Branch Feb 27, 2022
@kennethtran93
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants