Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a string placeholder in Turkish. Closes #1299 #1382

Merged
merged 2 commits into from May 8, 2022

Conversation

kennethtran93
Copy link
Member

@kennethtran93 kennethtran93 commented May 7, 2022

Not sure how this was missed before. Apologies.

This will fix #1299

Signed-off-by: Kenneth T 6724477+kennethtran93@users.noreply.github.com

@kennethtran93 kennethtran93 self-assigned this May 7, 2022
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #1382 (69c912c) into 3.X.X-Branch (cfc3c82) will not change coverage.
The diff coverage is n/a.

❗ Current head 69c912c differs from pull request most recent head 39f8e08. Consider uploading reports for the commit 39f8e08 to get more accurate results

@@              Coverage Diff              @@
##           3.X.X-Branch    #1382   +/-   ##
=============================================
  Coverage         47.82%   47.82%           
=============================================
  Files                34       34           
  Lines              2731     2731           
  Branches            821      821           
=============================================
  Hits               1306     1306           
  Misses             1424     1424           
  Partials              1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc3c82...39f8e08. Read the comment docs.

@coveralls
Copy link

coveralls commented May 7, 2022

Pull Request Test Coverage Report for Build 2288704367

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.71%

Totals Coverage Status
Change from base Build 2288690896: 0.0%
Covered Lines: 1013
Relevant Lines: 2062

💛 - Coveralls

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions github-actions bot deleted a comment from kennethtran93 May 7, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@kennethtran93
Copy link
Member Author

/get-build-beta

@github-actions

This comment has been minimized.

@kennethtran93
Copy link
Member Author

/get-build-beta

@github-actions

This comment has been minimized.

@kennethtran93
Copy link
Member Author

/get-build-beta

@github-actions

This comment has been minimized.

@github-actions github-actions bot deleted a comment from kennethtran93 May 8, 2022
@Cookie-AutoDelete Cookie-AutoDelete deleted a comment from github-actions bot May 8, 2022
@github-actions

This comment has been minimized.

@kennethtran93
Copy link
Member Author

kennethtran93 commented May 8, 2022

@kennethtran93 had previously requested download links for Build 2288570703 that have since expired.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@kennethtran93 kennethtran93 force-pushed the fix-turkish-translation branch 2 times, most recently from c8badb5 to 69c912c Compare May 8, 2022 05:59
Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@kennethtran93 kennethtran93 merged commit 4fc0f1f into 3.X.X-Branch May 8, 2022
@kennethtran93 kennethtran93 deleted the fix-turkish-translation branch May 8, 2022 06:01
@github-actions
Copy link

github-actions bot commented May 8, 2022

Pull Request Build: 2288704367

Unsigned webextension builds for testing is ready for download!
These test builds are only kept for up to 90 days from the date of this post.
It is strongly recommended to use a fresh profile for testing these builds to prevent any kind of modifications to existing data.

Generating Download Links

  • /get-build for the latest commit build.
  • /get-build 2288704367 for this specific commit 39f8e08 build.

When new command comment is posted, please allow a few seconds for the command to be received and processed.

  • 👀 indicates that command has been received.
  • 🚀 indicates that command has been sent for further processing.
  • 🎉 indicates that command has been executed. Expect a new comment with the result shortly.

Due to API limitations, generated links will only be valid for one minute!

@kennethtran93 kennethtran93 added the bugfix Pull Requests that fixes a bug raised from an issue. label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull Requests that fixes a bug raised from an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Plugin Not Loading. package is invalid
2 participants