Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanAllCookies option on import. #1389

Merged
merged 3 commits into from May 22, 2022

Conversation

kennethtran93
Copy link
Member

@kennethtran93 kennethtran93 commented May 16, 2022

Fixed conditional check to use imported value unless it is undefined.

Closes #1376.

Signed-off-by: Kenneth T 6724477+kennethtran93@users.noreply.github.com

@kennethtran93 kennethtran93 added the bugfix Pull Requests that fixes a bug raised from an issue. label May 16, 2022
@kennethtran93 kennethtran93 self-assigned this May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1389 (743dcea) into 3.X.X-Branch (c4260ca) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           3.X.X-Branch    #1389   +/-   ##
=============================================
  Coverage         47.89%   47.89%           
=============================================
  Files                34       34           
  Lines              2735     2735           
  Branches            825      825           
=============================================
  Hits               1310     1310           
  Misses             1424     1424           
  Partials              1        1           
Impacted Files Coverage Δ
src/redux/Actions.ts 38.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4260ca...743dcea. Read the comment docs.

@coveralls
Copy link

coveralls commented May 16, 2022

Pull Request Test Coverage Report for Build 2364792835

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.086%

Totals Coverage Status
Change from base Build 2364761747: 0.0%
Covered Lines: 1019
Relevant Lines: 2068

💛 - Coveralls

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@kennethtran93 kennethtran93 changed the title Fix cleanAllCookies option on import. Fixes #1376. Fix cleanAllCookies option on import. May 16, 2022
Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
@github-actions

This comment has been minimized.

Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
@github-actions
Copy link

Pull Request Build: 2364792835

Unsigned webextension builds for testing is ready for download!
These test builds are only kept for up to 90 days from the date of this post.
It is strongly recommended to use a fresh profile for testing these builds to prevent any kind of modifications to existing data.

Generating Download Links

  • /get-build for the latest commit build.
  • /get-build 2364792835 for this specific commit 743dcea build.

When new command comment is posted, please allow a few seconds for the command to be received and processed.

  • 👀 indicates that command has been received.
  • 🚀 indicates that command has been sent for further processing.
  • 🎉 indicates that command has been executed. Expect a new comment with the result shortly.

Due to API limitations, generated links will only be valid for one minute!

@kennethtran93 kennethtran93 merged commit ff11e5a into 3.X.X-Branch May 22, 2022
@kennethtran93 kennethtran93 deleted the keepAllCookie-import-fix branch May 22, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull Requests that fixes a bug raised from an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Export/Import of expressions does not keep setting "Keep all Cookies"
2 participants