Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger special localstorage clean function on 'All' manual cleanup #1404

Merged
merged 2 commits into from Jun 11, 2022

Conversation

kennethtran93
Copy link
Member

Fixes #1402.

This executes the clean localstorage function created to include sessionstorage cleanup. While Chrome does clean up session storage via browsingdata API when localstorage is passed in (at least that's what it looks like on testing), Firefox does not.

Doing this will double-clean the localstorage for that domain, but at least we make sure session storage is also cleaned up (especially on Firefox).

Signed-off-by: Kenneth T 6724477+kennethtran93@users.noreply.github.com

…leanup.

Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
@kennethtran93 kennethtran93 added the bugfix Pull Requests that fixes a bug raised from an issue. label Jun 5, 2022
@kennethtran93 kennethtran93 self-assigned this Jun 5, 2022
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #1404 (b1e3e0e) into 3.X.X-Branch (3f54a09) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           3.X.X-Branch    #1404      +/-   ##
================================================
- Coverage         47.92%   47.90%   -0.02%     
================================================
  Files                34       34              
  Lines              2748     2749       +1     
  Branches            835      835              
================================================
  Hits               1317     1317              
- Misses             1430     1431       +1     
  Partials              1        1              
Impacted Files Coverage Δ
src/ui/popup/components/CleanDataButton.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f54a09...b1e3e0e. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 5, 2022

Pull Request Test Coverage Report for Build 2441334388

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 50.157%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ui/popup/components/CleanDataButton.tsx 0 3 0.0%
Totals Coverage Status
Change from base Build 2441181596: -0.03%
Covered Lines: 1023
Relevant Lines: 2075

💛 - Coveralls

@github-actions

This comment has been minimized.

Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Pull Request Build: 2441334388

Unsigned webextension builds for testing is ready for download!
These test builds are only kept for up to 90 days from the date of this post.
It is strongly recommended to use a fresh profile for testing these builds to prevent any kind of modifications to existing data.

Generating Download Links

  • /get-build for the latest commit build.
  • /get-build 2441334388 for this specific commit b1e3e0e build.

When new command comment is posted, please allow a few seconds for the command to be received and processed.

  • 👀 indicates that command has been received.
  • 🚀 indicates that command has been sent for further processing.
  • 🎉 indicates that command has been executed. Expect a new comment with the result shortly.

Due to API limitations, generated links will only be valid for one minute!

@kennethtran93
Copy link
Member Author

kennethtran93 commented Jun 5, 2022

This user had previously requested download links for build 2441334388 that have since expired.

@kennethtran93 kennethtran93 merged commit 69221f3 into 3.X.X-Branch Jun 11, 2022
@kennethtran93 kennethtran93 deleted the clean-sessionstorage-manual-all branch June 11, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull Requests that fixes a bug raised from an issue.
Projects
None yet
2 participants