Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depupdates 202212 #1469

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Depupdates 202212 #1469

merged 2 commits into from
Dec 8, 2022

Conversation

kennethtran93
Copy link
Member

And now that typescript has patched itself to know what FileReader.result returns, I don't need the workaround anymore.

Signed-off-by: Kenneth T 6724477+kennethtran93@users.noreply.github.com

Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
@kennethtran93 kennethtran93 added the dependencies Pull requests that update a dependency file label Dec 8, 2022
@kennethtran93 kennethtran93 self-assigned this Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Pull Request Build: 3644696500

Unsigned webextension builds for testing is ready for download!
These test builds are only kept for up to 90 days from the date of this post.
It is strongly recommended to use a fresh profile for testing these builds to prevent any kind of modifications to existing data.

Clickable Download Links (BETA)

NOTE: Ensure you are already signed into GitHub before clicking on the links below.

Filename Created Timestamp Expiry Timestamp
Cookie-AutoDelete_Dev_20221208_023401_a73098a_Chrome 2022-12-08 @ 02:34:21Z UTC 2023-03-08 @ 02:34:10Z UTC
Cookie-AutoDelete_Dev_20221208_023401_a73098a_Firefox 2022-12-08 @ 02:34:21Z UTC 2023-03-08 @ 02:34:05Z UTC

Please note that if the link(s) above returns a 404 Not Found, you may not be signed into GitHub, or it may have expired and/or manually removed before expiry date. This post does not get updated if artifacts are removed. Try the alternate method below if the link(s) above do not work.

To Generate Download Links (Alternate Method if above links do not work for some reason)

  • /get-build for the latest commit build.
  • get-build 3644696500 for this specific commit a73098a build.

When new command comment is posted, please allow a few seconds for the command to be received and processed.

  • 👀 indicates that command has been received.
  • 🚀 indicates that command has been sent for further processing.
  • 🎉 indicates that command has been executed. Expect a new comment with the result shortly.

Due to API limitations, generated links from the alternate method will only be valid for one minute!

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1469 (a73098a) into 3.X.X-Branch (e89a46c) will increase coverage by 0.22%.
The diff coverage is 90.32%.

@@               Coverage Diff                @@
##           3.X.X-Branch    #1469      +/-   ##
================================================
+ Coverage         47.90%   48.13%   +0.22%     
================================================
  Files                34       34              
  Lines              2749     2761      +12     
  Branches            835      844       +9     
================================================
+ Hits               1317     1329      +12     
  Misses             1431     1431              
  Partials              1        1              
Impacted Files Coverage Δ
src/ui/settings/components/Expressions.tsx 0.00% <0.00%> (ø)
src/services/CleanupService.ts 100.00% <100.00%> (ø)
src/services/Libs.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kennethtran93 kennethtran93 merged commit 648b88c into 3.X.X-Branch Dec 8, 2022
@kennethtran93 kennethtran93 deleted the depupdates-202212 branch December 8, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant