New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note generator for safe accidentals #35

Closed

CookieComputing opened this issue Apr 21, 2021 · 1 comment

Labels

enhancement good first issue

Owner

CookieComputing commented Apr 21, 2021

We need to have a note generator that generates letters and a single type of accidental for scales, keys, and chords.

Currently, we use this pattern:

val minorPentatonicScaleGen: Gen[MinorPentatonicScale] = for {
    letter <- NoteTest.noteLetterGen
    numOfAccidentals <- Gen.chooseNum(0, 1000)
    accidental <- NoteTest.accidentalGen
  } yield (...)

which can be refactored into a generator that does this for us

CookieComputing added enhancement good first issue labels

CookieComputing mentioned this issue

Cut down testing/CPU time on Major/MinorPentatonic Scale #37

Closed

Owner Author

CookieComputing commented Apr 22, 2021

Closed by fbff484

CookieComputing closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment