Firefox 57 / Greasemonkey 4 userscript

[Pantalaim0n]

The Greasemonkey userscript stopped working for me today after upgrading to firefox 57 (Quantum) / Greasemonkey 4

I made some changes to get it to work again:

// ==UserScript==
// @name Cookie Monster
// @namespace Cookie
// @include http://orteil.dashnet.org/cookieclicker/
// @version 1
// @grant none
// ==/UserScript==

javascript:(function() {
    var checkReady = setInterval(function() {
        if (typeof unsafeWindow.Game.ready !== 'undefined' && unsafeWindow.Game.ready) {
            unsafeWindow.Game.LoadMod('http://aktanusa.github.io/CookieMonster/CookieMonster.js');
            clearInterval(checkReady);
        }
    }, 1000);
}());

The Game object is undefined, but with the prefix unsafeWindow it works again.

[Aktanusa]

Hmm, interesting. Do you know if it works fine with other browsers with your changes like Google Chrome?

[Pantalaim0n]

It works in Chrome / Tampermonkey if I remove the line // @grant none.
Removing the same line in FireFox makes no difference, it works in both cases.

[Aktanusa]

Thanks for the research. I'll take a look if there is another way instead of using unsafeWindow since apparently it is not recommended to use it.

[cpeter256]

I've been using the following script successfully-- window.eval appears to be the recommended way to run code inside the security context of the page, instead of greasemonkey's context

var code = "(" + (function() {
  var checkReady = setInterval(function() {
    if (typeof Game.ready !== 'undefined' && Game.ready) {
      Game.LoadMod('http://aktanusa.github.io/CookieMonster/CookieMonster.js');
      clearInterval(checkReady);
    }
  }, 1000);
}).toString() + ")()";

window.eval(code);

[Aktanusa]

Thanks! I'll will probably use that instead of unsafeWindow. Should be updated when I updated CM to latest CC.

[Aktanusa]

Fixed in version 2.0045.1