Add TLS to HTTP links #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please use HTTPS wherever it is supported. It is just good practise, you know. This follows up commit 98924bc.
|
I agree this is a good idea, but why the two pull requests? I see one is to master and other to dev, but it should be only to dev first, as that's the order to go to master. |
|
Thought the other one goes to |
|
Hmm, it is true that it's just a README change, so nothing to test, but then the gh-pages branch needs it too, lol. |
HTTPS is good to push for wherever possible, even if the Cookie Clicker site itself does not support it now. (cherry picked from commit 98924bc)
Closed
|
Let's just go the regular route then. |
|
Well I am going to be doing an update to master and gh-pages soon anyway, due to the new version of CC, lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use HTTPS wherever it is supported. It is just good practise, you know.