Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to update the package so that a user could just type
]add https://github.com/CoolProp/CoolProp.jl
and have a working version of CoolProp on julia.In this PR I updated CoolProp.jl to utilize the files Project.toml and Manifest.toml to list all the dependencies of the package. This is the new standard in julia v1. The new package manager bundled with julia 1.x helps in the automatic generation of these files.
Yet, using the new package manager was not sufficient to run successfully
]add https://github.com/alblaz/CoolProp.jl#update-to-julia-v1.0
.and I got an error in the build process related to the line
const branchname = LibGit2.branch(LibGit2.GitRepo(abspath(@__FILE__, "..", "..")));
In order to get rid of this error I had to force
branchname = "master"
in build.jl . This is not an ideal fix and I think build.jl should be changed somehow. Yet now it is possible to run]add https://github.com/alblaz/CoolProp.jl#update-to-julia-v1.0
and build a working CoolProp.jl.Let me know your thoughts and your suggestions to modify build.jl,
Alberto
P.S. I noticed that 2 tests are failing for some reason. The tests are at line 10 and 11 in TestThrows.jl. I commented out these tests temporarily to check that everything else is working.