Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with incompressible fluid in v6.2.1 #1756

Closed
DanWBR opened this issue Oct 31, 2018 · 4 comments · Fixed by #1765
Closed

Issue with incompressible fluid in v6.2.1 #1756

DanWBR opened this issue Oct 31, 2018 · 4 comments · Fixed by #1765
Assignees
Labels
Milestone

Comments

@DanWBR
Copy link

DanWBR commented Oct 31, 2018

Calling

PropsSI("H", "T", 325.15, "P", 3800, "INCOMP::LiBr[0]")

throws an exception on the latest version (6.2.1):

System.ApplicationException
HResult=0x80131600
Message=Initialize failed for backend: "INCOMP", fluid: "" fractions ""; error: key [] was not found in string_to_index_map in JSONIncompressibleLibrary

On v6.1.0, it returns

67181.93463102358

Tested with the C# version on Windows and Darwin 64-bit.

@jowr
Copy link
Member

jowr commented Nov 5, 2018

Thank you for the bug report. I am going to have a look at this.

@henningjp
Copy link
Contributor

I noticed this as well. The Mathcad verification sheet tests "INCOMP::MITSW[0]" and it says the fluid string is invalid. This could be related to the patch we put in for dropping mixture components that have a mole fraction of zero from the mixture calculation under HEOS. I bet it needs a backend check so that it leaves INCOMP fluid strings alone. I can peak at it as well.

@jowr jowr added this to the v6.2.2 milestone Dec 4, 2018
@henningjp henningjp self-assigned this Dec 4, 2018
@henningjp henningjp added the bug label Dec 4, 2018
@henningjp
Copy link
Contributor

@DanWBR This will be an easy fix. In the mean time, using the dash notation still works. So you can use fluid strings like "INCOMP::LiBr-0%".

@DanWBR
Copy link
Author

DanWBR commented Dec 5, 2018

Thanks @henningjp. I'll wait for a fixed version, using v6.1.0 in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants