Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update State class #2277

Closed
ibell opened this issue Aug 6, 2023 · 0 comments
Closed

Update State class #2277

ibell opened this issue Aug 6, 2023 · 0 comments
Milestone

Comments

@ibell
Copy link
Contributor

ibell commented Aug 6, 2023

The State class has a few problems when using the HEOS backend with mixtures in PDSim. For one, the phase flag is never able to be used due to a bytes <-> str type mismatch in the comparison and also, the AbstractState class being managed is not accessible, and some methods are only available in the AbstractState class (for instance first_partial_deriv). So the pointer has been exposed, and the phase is handled (more) properly now.

@ibell ibell added this to the v6.5.0 milestone Aug 6, 2023
@ibell ibell closed this as completed Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant