Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't scroll minutes on iPhone5 in landscape mode #42

Closed
avgx opened this issue Jan 30, 2015 · 9 comments
Closed

Can't scroll minutes on iPhone5 in landscape mode #42

avgx opened this issue Jan 30, 2015 · 9 comments
Labels

Comments

@avgx
Copy link

avgx commented Jan 30, 2015

To reproduce:
start demo project
rotate in landscape mode
press "Show date..."

If I rotate after showing the control - all works as expected.

@CooperRS
Copy link
Owner

Works for me in simulator and on a real device. Which system language/locale are you using? (As I only tested with german and us locale)

@avgx
Copy link
Author

avgx commented Jan 30, 2015

in simulator.
en
If found that the issue is due to

        if([[[UIDevice currentDevice] systemVersion] floatValue] >= 8.0 && UIInterfaceOrientationIsLandscape([UIApplication sharedApplication].statusBarOrientation)) {
            aDateSelectionViewController.window.frame = CGRectMake(0, 0, [[UIScreen mainScreen] bounds].size.height, [[UIScreen mainScreen] bounds].size.width);
        }

in

+ (void)showDateSelectionViewController:(RMDateSelectionViewController *)aDateSelectionViewController animated:(BOOL)animated

And I'm prepareing PR, but i haven't solved all cases where i need to put

[aDateSelectionViewController.datePicker layoutIfNeeded];

@CooperRS
Copy link
Owner

OK, then I'm waiting for your PR :)

@avgx
Copy link
Author

avgx commented Feb 3, 2015

Can't get the things working :(
Reproduced with real device iphone5s

  1. Start demo
  2. rotate UIInterfaceOrientationLandscapeRight
  3. press "show date..."
  4. the minutes are unavailable to scroll
  5. if then rotate to portrait - can't press select button
    It seems like touch area is only on original place (where no transform)
    If I press "show date..." in portrait orientation - all is perfect for all rotations.

avgx pushed a commit to avgx/RMDateSelectionViewController that referenced this issue Feb 5, 2015
shame on me, but I can't get the things working, so it's a temporary solution
@CooperRS
Copy link
Owner

CooperRS commented Feb 6, 2015

Hmm, I could not find a solution for myself as I could not find the reason why the touch area is broken. But I'll keep working...

@avgx
Copy link
Author

avgx commented Feb 6, 2015

I've found the working code in https://github.com/Busta117/SBPickerSelector but I can't integrate it here, not enouph experience in ios yet.

@CooperRS CooperRS added the bug label Mar 26, 2015
@CooperRS
Copy link
Owner

CooperRS commented Apr 5, 2015

Acutally this bug should be fixed by using custom transitions instead of UIWindows. I would appreciate if you could take a look at the branch AppExtensions and try to reproduce this bug with this branch :)

@CooperRS
Copy link
Owner

CooperRS commented Apr 5, 2015

You may now also try the pod version 1.5.0 ;)

@CooperRS
Copy link
Owner

CooperRS commented May 1, 2015

Closing due to missing response.

@CooperRS CooperRS closed this as completed May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants