Serverless offline 6 #125
Serverless offline 6 #125
Conversation
|
Note for maintainers. I can’t get the python test to pass. Can someone who knows about running python on serverless take a look? |
esetnik
force-pushed
the
serverless-offline-6
branch
from
24f1d0c
to
e0a511c
Compare
| @@ -56,6 +53,14 @@ class ServerlessOfflineSQS { | |||
| 'before:offline:start:end': this.offlineStartEnd.bind(this) | |||
| }; | |||
|
|
|||
| this.serverlessOfflinePlugin = this.serverless.pluginManager.plugins.find( | |||
There was a problem hiding this comment.
For me, this doesn't find anything even though I do have serverless-offline-sqs plugin installed... Are you sure this is the best way to find it?
There was a problem hiding this comment.
I couldn't find any better way to hook into the serverless-offline plugin. The plugin order matters. Make sure that - serverless-offline appears before - serverless-offline-sqs in your serverless.yml
There was a problem hiding this comment.
Yup, that was it - after changing the order I can approve that it works on my side. (tested with serverless-offline versions 6.1.0 and 6.1.4)
|
@AdrieanKhisbe can you take a look please? |
|
Any plans to look at this soon? |
|
waiting for this :( |
|
Thanks for this @esetnik, this is working for me against serverless-offline I published a version on npm as https://www.npmjs.com/package/serverless-offline-sqs-elastic |
|
Never mind my previous response, I get it now. It does seem to alleviate the main error but I haven't had a chance to actually test the functionality yet :-D |
|
Hi, i'm working on full rewrite to support serverless v6. |
Resolves #116, #122
Note that to achieve this there's a pretty big hack. I need to access the private class property #lambda. See https://github.com/CoorpAcademy/serverless-plugins/pull/125/files#diff-32e9d7d10726a2f50f1aea57d090602cR196