Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drain if NextShardIterator is missing #37

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Conversation

zoellner
Copy link
Contributor

fixes #36

This fixes the issue but I'm not totally sure that this is how the drain variable is meant to be used. Comments welcome.

@eduardoromero
Copy link

I was having a similar issue that #36 getting: MissingRequiredParameter: Missing required key 'ShardIterator' in params.

Debugging it got to the same point, and can confirm that the stream is now working with LATEST 👍

@zoellner
Copy link
Contributor Author

Merged in latest from master. All checks now passing.
@godu can this be merged?

@godu godu merged commit 53130a4 into CoorpAcademy:master Apr 26, 2019
@godu
Copy link
Contributor

godu commented Apr 26, 2019

@zoellner thanks a lot for this contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LATEST as startingPosition doesn't work
3 participants