Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix empty value #66

Merged
merged 3 commits into from
Sep 26, 2016
Merged

fix empty value #66

merged 3 commits into from
Sep 26, 2016

Conversation

lcalvy
Copy link
Contributor

@lcalvy lcalvy commented Sep 26, 2016 •
edited by godu
Loading

@godu this is needed

  • de plus le set n'est plus scoppé

image

  • le res du set renvoie un result etcd, ca devrait etre la value du noeud?

image

@coveralls
Copy link

coveralls commented Sep 26, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 2436afa on expoise-api-stringify into 8d5a358 on expose-api-set.

lcalvy
lcalvy commented Sep 26, 2016
View reviewed changes
src/api.js
import {set$} from './util/etcd';
import createDebug from 'debug';

const debug = createDebug('squirrel');

const createAPI = (store, client) => {
const createAPI = (store, client, options = {cwd: '/'}) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;-)

lcalvy
lcalvy commented Sep 26, 2016
View reviewed changes
src/api.js
@@ -30,7 +31,12 @@ const createAPI = (store, client) => {
};

const set = (_path, value) => {
return set$(client, _path, JSON.stringify(value, null, 4)).toPromise();
_path = path.join(options.cwd, _path);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finalement je fais pas que de la merde :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah :D

@coveralls
Copy link

coveralls commented Sep 26, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 7dc8d5b on expoise-api-stringify into 8d5a358 on expose-api-set.

@coveralls
Copy link

coveralls commented Sep 26, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 7dc8d5b on expoise-api-stringify into 8d5a358 on expose-api-set.

@coveralls
Copy link

coveralls commented Sep 26, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 7dc8d5b on expoise-api-stringify into 8d5a358 on expose-api-set.

@godu godu merged commit 61271af into expose-api-set Sep 26, 2016
@godu godu deleted the expoise-api-stringify branch September 26, 2016 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godu godu godu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lcalvy @coveralls @godu