-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mkdir #89
Conversation
1 similar comment
.eslintrc
Outdated
@@ -4,6 +4,13 @@ | |||
"node": true | |||
}, | |||
"parser": "babel-eslint", | |||
"parserOptions": { | |||
"ecmaVersion": 2017, | |||
"ecmaFeatures": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
À enlever
]); | ||
}); | ||
test('should return error if entry is neither a file nor a directory', t => | ||
t.notThrows( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je suis quasi-sûr que tu dois quand même retourner t.throws(...)
, sinon le test n'attendra pas la fin de la Promise. (Donc à gérer partout)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est la cas. t => t.notThrows()
≠ t => { t.notThrows(); }
Quand on lance squirrel sur un dossier qui n'existe pas dans etcd, les requests
get
attendent la création du noeud. Pour pallier à ce problème, à chaque lancement, on essaie de créer le dossier.