Preloaded store #90
Merged
Preloaded store #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmengels
reviewed
Dec 13, 2017
|
|
||
| createSave(pathFS)(fetch$) | ||
| .toPromise() | ||
| .then(() => process.stdout.write('The end.\n')) |
There was a problem hiding this comment.
Par curiosité, pourquoi process.stdout.write plutôt que console.log ?
There was a problem hiding this comment.
console.log c'est utilisé pour debugger. Là, je fais un CLI et c'est avec STDOUT que je veux travailler. J'ai assez subtil et discutable.
jfmengels
reviewed
Dec 13, 2017
src/test/fallback.js
Outdated
| @@ -22,3 +23,16 @@ test("shouldn't throw error if file doesn't exist", async t => { | |||
| .toPromise(); | |||
| t.deepEqual(events, []); | |||
| }); | |||
|
|
|||
| test("should load preloadedStore if fallback doesn't exists", async t => { | |||
There was a problem hiding this comment.
Rajoute peut-être un test dans le cas où preloadedStore est undefined/null ?
godu
force-pushed
the
preloaded-store
branch
from
42317ac
to
6d577c3
Compare
dawee
reviewed
Dec 13, 2017
| Write ETCD folder in `preloadedStore` format. | ||
|
|
||
| ```Shell | ||
| $ squirrel-dump --hosts localhost:2379 /etcd-folder ./dump.json |
There was a problem hiding this comment.
Et du coup cette commande va aller dans un cron en prod ?
There was a problem hiding this comment.
elle va aller dans la phase de build du mooc.
dawee
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.