Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider 0.10 as stable and 0.11 as nightly #322

Merged
merged 2 commits into from
May 17, 2024

Conversation

frolvanya
Copy link
Contributor

closes #321

Let's consider 0.10 as stable version from now on. I suppose 0.9.5 still can be considered as stable for a few months until majority of people will migrate to 0.10

lua/CopilotChat/health.lua Outdated Show resolved Hide resolved
lua/CopilotChat/health.lua Outdated Show resolved Hide resolved
@frolvanya frolvanya requested a review from deathbeam May 17, 2024 12:41
@deathbeam deathbeam merged commit 4c71c86 into CopilotC-Nvim:canary May 17, 2024
1 check passed
@deathbeam
Copy link
Collaborator

@all-contributors add @frolvanya for code

Copy link
Contributor

@deathbeam

I've put up a pull request to add @frolvanya! 🎉

@WillEhrendreich
Copy link

I'm on a nightly of 0.11.0 but checkhealth fails and says I should upgrade.
image

@deathbeam
Copy link
Collaborator

Oh the commit number is since last release, need to fix that

@frolvanya
Copy link
Contributor Author

Oh the commit number is since last release, need to fix that

Oops, I messed up. Do you want me to fix it? If so, do you want to completely remove this section with >= 2500 or replace it with >= 67 (since neovim-0.11 has dev number 67)

@deathbeam
Copy link
Collaborator

Oh the commit number is since last release, need to fix that

Oops, I messed up. Do you want me to fix it? If so, do you want to completely remove this section with >= 2500 or replace it with >= 67 (since neovim-0.11 has dev number 67)

Oh the commit number is since last release, need to fix that

Oops, I messed up. Do you want me to fix it? If so, do you want to completely remove this section with >= 2500 or replace it with >= 67 (since neovim-0.11 has dev number 67)

Nah wasnt your fault just did not realized it works like this. I already fixed it here: #331 . If we have nvim 0.11.0 it will just consider any dev version as valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed a checkhealth operation
3 participants