Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for Rails 3/4 #2

Merged
merged 1 commit into from Dec 27, 2013
Merged

updated for Rails 3/4 #2

merged 1 commit into from Dec 27, 2013

Conversation

Beartech
Copy link
Contributor

I pulled down the sample app for Seer and did a quick and dirty update to get it working under Rails 3/4. I am running Rails 4, but I don't think there's anything that won't work with 3.2. The only error I can see is the images/background.png is not being found by the web server. But all of the charts work. I had to set most ":colors => []" to get color working in the charts. The geo-map chart comes up but does not show any data on the map. This would let people using modern versions of Rails check out the gem. Don't know if you would want to archive the old version for anyone running Rails 2, but if they are building a new app they should probably be on v4. BTW this is a great gem!

CoralineAda pushed a commit that referenced this pull request Dec 27, 2013
@CoralineAda CoralineAda merged commit b92d6fb into CoralineAda:master Dec 27, 2013
@CoralineAda
Copy link
Owner

Awesome, thanks for all your work on this!

Best,
Corey

On Dec 27, 2013, at 1:30 AM, Andy Reilly notifications@github.com wrote:

I pulled down the sample app for Seer and did a quick and dirty update to get it working under Rails 3/4. I am running Rails 4, but I don't think there's anything that won't work with 3.2. The only error I can see is the images/background.png is not being found by the web server. But all of the charts work. I had to set most ":colors => []" to get color working in the charts. The geo-map chart comes up but does not show any data on the map. This would let people using modern versions of Rails check out the gem. Don't know if you would want to archive the old version for anyone running Rails 2, but if they are building a new app they should probably be on v4. BTW this is a great gem!

You can merge this Pull Request by running

git pull https://github.com/Beartech/seer_sample master
Or view, comment on, or merge it at:

#2

Commit Summary

updated for Rails 3/4
File Changes

A Gemfile (48)
A Gemfile.lock (121)
M README.rdoc (29)
M Rakefile (8)
A app/assets/.DS_Store (0)
R app/assets/images/.keep (0)
R app/assets/images/background.png (0)
R app/assets/images/blockquote_bg.png (0)
R app/assets/images/rails.png (0)
R app/assets/images/seer_logo_small.png (0)
R app/assets/javascripts/application copy.js (0)
A app/assets/javascripts/application.js (14)
R app/assets/javascripts/controls.js (0)
R app/assets/javascripts/dragdrop.js (0)
R app/assets/javascripts/effects.js (0)
R app/assets/javascripts/prototype.js (0)
A app/assets/stylesheets/.DS_Store (0)
A app/assets/stylesheets/application.css.scss.css (14)
R app/assets/stylesheets/core.css.scss.css (0)
M app/controllers/application_controller.rb (12)
R app/controllers/concerns/.keep (0)
M app/helpers/application_helper.rb (1)
R app/mailers/.keep (0)
A app/models/.keep (0)
A app/models/concerns/.keep (0)
M app/views/home/area_chart.html.erb (6)
M app/views/home/bar_chart.html.erb (12)
M app/views/home/column_chart.html.erb (2)
M app/views/home/gauge.html.erb (2)
M app/views/home/geo_chart.html.erb (11)
M app/views/home/line_chart.html.erb (6)
M app/views/home/pie_chart.html.erb (4)
M app/views/layouts/application.html.erb (10)
A assets/.keep b/lib/assets/.keep (0)
A bin/bundle (3)
A bin/rails (4)
A bin/rake (4)
A config.ru (4)
A config/application.rb (23)
M config/boot.rb (112)
M config/database.yml (5)
M config/environment.rb (44)
M config/environments/development.rb (38)
M config/environments/production.rb (92)
M config/environments/test.rb (64)
M config/initializers/backtrace_silencers.rb (4)
A config/initializers/filter_parameter_logging.rb (4)
M config/initializers/inflections.rb (12)
D config/initializers/new_rails_defaults.rb (21)
A config/initializers/secret_token.rb (12)
M config/initializers/session_store.rb (14)
A config/initializers/wrap_parameters.rb (14)
M config/locales/en.yml (24)
M config/routes.rb (50)
M db/development.sqlite3 (0)
M db/schema.rb (42)
M db/seeds.rb (2)
M log/development.log (7836)
M public/404.html (66)
M public/422.html (66)
M public/500.html (65)
A public/images/.DS_Store (0)
A public/javascripts/.DS_Store (0)
M public/robots.txt (2)
A public/stylesheets/.DS_Store (0)
A tasks/.keep b/lib/tasks/.keep (0)
A test.sqlite3 b/db/test.sqlite3 (0)
A test/controllers/.keep (0)
A test/fixtures/.keep (0)
A test/helpers/.keep (0)
A test/integration/.keep (0)
A test/mailers/.keep (0)
A test/models/.keep (0)
A test/test_helper.rb (15)
A vendor/assets/images/.keep (0)
A vendor/assets/images/background.png (0)
A vendor/assets/images/blockquote_bg.png (0)
A vendor/assets/images/rails.png (0)
A vendor/assets/images/seer_logo_small.png (0)
A vendor/assets/javascripts/.keep (0)
A vendor/assets/stylesheets/.keep (0)
Patch Links:

https://github.com/Bantik/seer_sample/pull/2.patch
https://github.com/Bantik/seer_sample/pull/2.diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants